Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more array types, add imshow #3

Merged
merged 16 commits into from
Jun 8, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jun 8, 2024

  • fixes some bugs
  • adds imshow() convenience
  • adds ndv.data convenience
  • adds/extends support for more array types
  • tests all examples

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 91.95402% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69.14%. Comparing base (1b07c50) to head (2f3e4fd).
Report is 2 commits behind head on main.

Current head 2f3e4fd differs from pull request most recent head b626d4b

Please upload reports for the commit b626d4b to get more accurate results.

Files Patch % Lines
src/ndv/viewer/_data_wrapper.py 93.98% 11 Missing ⚠️
src/ndv/viewer/_viewer.py 63.15% 7 Missing ⚠️
src/ndv/util.py 90.90% 2 Missing ⚠️
src/ndv/data.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   62.01%   69.14%   +7.13%     
==========================================
  Files          10       12       +2     
  Lines        1103     1157      +54     
==========================================
+ Hits          684      800     +116     
+ Misses        419      357      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title misc updates many updates Jun 8, 2024
@tlambert03 tlambert03 changed the title many updates support more array types, add imshow Jun 8, 2024
@tlambert03 tlambert03 merged commit 71aa18e into pyapp-kit:main Jun 8, 2024
10 checks passed
@tlambert03 tlambert03 deleted the updates branch June 8, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant