-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leakage in Windows #27
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 81.92% 81.93%
=======================================
Files 13 13
Lines 1234 1251 +17
=======================================
+ Hits 1011 1025 +14
- Misses 223 226 +3 ☔ View full report in Codecov by Sentry. |
Hey @hanjinliu, lovely seeing you here! 😀 I saw this as well and added pyapp-kit/superqt#247 to superqt (which is in the latest release)... but I haven't tested on windows yet! Are you definitely updated on superqt? |
Hi @tlambert03, I'm very excited about this package! |
Great! Good to hear :) |
Shall we still turn this PR into fixing whatever else is left for windows tests? (It's ok if we need to make some leak concessions, as you'll see I've already done with Linux) |
Other fixes will be completely different from what I did here anyway. I think we can just close this PR and make new one later when the solution is found. |
Ok well thanks for popping in! |
Maybe related to #8.
I found that
qthrottled
holds the reference to the widget instance (viamethod.__self__
?) and this prevented proper cleanups in Windows. This problem can be solved by using an weak reference inside a local function as is done in this PR, but probably should be somehow handled onsuperqt
side (although I'm not sure if it's possible).