Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tensorstore isel #25

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix: tensorstore isel #25

merged 2 commits into from
Jun 12, 2024

Conversation

tlambert03
Copy link
Member

fixes a bug when indexing tensorstore

@tlambert03 tlambert03 marked this pull request as ready for review June 12, 2024 19:35
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (388965f) to head (d561ed3).

Files Patch % Lines
src/ndv/viewer/_data_wrapper.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   81.26%   82.90%   +1.63%     
==========================================
  Files          13       13              
  Lines        1217     1234      +17     
==========================================
+ Hits          989     1023      +34     
+ Misses        228      211      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit e606d53 into pyapp-kit:main Jun 12, 2024
15 of 16 checks passed
@tlambert03 tlambert03 deleted the fix-ts branch June 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant