feat: added tile command to cli #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinThoma
reviewed
Nov 6, 2023
pdfly/tiles.py
Outdated
|
|
||
| """ | ||
|
|
||
| # Stanislav Ulrych <[email protected]>. |
There was a problem hiding this comment.
Please don't add such comments
MartinThoma
reviewed
Nov 6, 2023
pdfly/tiles.py
Outdated
| ysize = PaperSize.A4.height | ||
|
|
||
| writer = PdfWriter() | ||
| destPage = writer.add_blank_page(width=xsize, height=ysize) |
There was a problem hiding this comment.
Please follow PEP-8:
Suggested change
| destPage = writer.add_blank_page(width=xsize, height=ysize) | |
| dest_page = writer.add_blank_page(width=xsize, height=ysize) |
MartinThoma
reviewed
Nov 6, 2023
pdfly/tiles.py
Outdated
| sys.exit(1) | ||
| finally: | ||
| output_fh.close() | ||
| # In 3.0, input files must stay open until output is written. |
There was a problem hiding this comment.
Isn't that true for Python 2.x as well ... and any programming language for that matter?
Suggested change
| # In 3.0, input files must stay open until output is written. |
MartinThoma
reviewed
Nov 6, 2023
pdfly/tiles.py
Outdated
| "tx": (i % xcount)*(xsize/xcount), | ||
| "ty": -(i // xcount)*(ysize/ycount) | ||
| } | ||
| print(t) |
Can you share an example input / output here in the comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
tilecommand, which can be used for tiling multiple stickers for printing in sticker papers.