Support io.reactivex.Maybe #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
============================================
- Coverage 97.68% 97.66% -0.02%
- Complexity 819 829 +10
============================================
Files 97 98 +1
Lines 2719 2744 +25
Branches 299 302 +3
============================================
+ Hits 2656 2680 +24
Misses 35 35
- Partials 28 29 +1
Continue to review full report at Codecov.
|
nikitin-da
approved these changes
Nov 27, 2017
| } | ||
|
|
||
| @Override | ||
| public void subscribe(MaybeEmitter<Result> emitter) throws Exception { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#846
#855
I've added Maybe support only to
PreparedGetObject. After some thoughts, I came to a conclusion that it doesn't really make much sense to have it for other queries. Maybe is some kind of a reactive optional and in case ofList,CursorandNumberOfResultsqueries we always have a valid result for empty cases so I don't see any value in wrapping them intoMaybe.