refactor: update setWindowOpenHandler in app.ts to handle additional …

…features
purocean · Oct 9, 2024 · c45e991 · c45e991
1 parent e5e9559
commit c45e991
Showing 1 changed file with 25 additions and 2 deletions.
diff --git a/src/main/app.ts b/src/main/app.ts
@@ -634,7 +634,7 @@ if (!gotTheLock) {
       })
     })
 
-    webContents.setWindowOpenHandler(({ url }) => {
+    webContents.setWindowOpenHandler(({ url, features }) => {
       if (url.includes('__allow-open-window__')) {
         return { action: 'allow' }
       }
@@ -652,7 +652,30 @@ if (!gotTheLock) {
         return { action: 'deny' }
       }
 
-      return { action: 'allow' }
+      const webPreferences: Record<string, boolean | string> = {}
+
+      // electron not auto parse features below. https://www.electronjs.org/docs/latest/api/window-open
+      const extraFeatureKeys = [
+        'experimentalFeatures',
+        'nodeIntegrationInSubFrames',
+        'webSecurity',
+      ]
+
+      extraFeatureKeys.forEach(key => {
+        const match = features.match(new RegExp(`${key}=([^,]+)`))
+        if (match) {
+          webPreferences[key] = match[1] === 'true' ? true : match[1] === 'false' ? false : match[1]
+        }
+      })
+
+      debugger
+
+      return {
+        action: 'allow',
+        overrideBrowserWindowOptions: {
+          webPreferences: Object.keys(webPreferences).length > 0 ? webPreferences : undefined,
+        }
+      }
     })
   })
 }