Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix removing default template #357

Merged
merged 1 commit into from
May 21, 2024

Conversation

mayankpatibandla
Copy link
Member

@mayankpatibandla mayankpatibandla commented May 21, 2024

Summary:

Instead of removing the template from the list, it will instead skip over it when applying the templates.

Motivation:

There is a bug introduced in 3.5.2 where okapilib is removed from the default templates list when creating a new project which causes issues when creating multiple projects.

Test Plan:

  • Create two projects and check if the second one causes an error

On master:
image

On hotfix/remove-default-templates:
image

@mayankpatibandla mayankpatibandla self-assigned this May 21, 2024
@mayankpatibandla mayankpatibandla changed the base branch from develop to master May 21, 2024 21:45
@mayankpatibandla mayankpatibandla force-pushed the hotfix/remove-default-templates branch from 95a6d39 to 07385bb Compare May 21, 2024 21:48
@mayankpatibandla mayankpatibandla merged commit e1de29b into master May 21, 2024
8 checks passed
@mayankpatibandla mayankpatibandla deleted the hotfix/remove-default-templates branch May 21, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants