Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Release 3.5.2 #353

Merged
merged 6 commits into from
May 18, 2024
Merged

🔖 Release 3.5.2 #353

merged 6 commits into from
May 18, 2024

Conversation

mayankpatibandla and others added 6 commits May 1, 2024 18:23
* Apply liblvgl when upgrading from PROS 3 to PROS 4

* Fetch template if necessary
* Update version numbers

* 🐛 Fix default template selection #318

* Update version numbers

* Update version numbers

---------

Co-authored-by: BennyBot <[email protected]>
Copy link
Contributor

@noam987 noam987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. if it is tested and won't be an issue, LGTM and I will apprrove

@@ -159,7 +159,7 @@ def upgrade(ctx: click.Context, project: c.Project, query: c.BaseTemplate, **kwa
"""
analytics.send("upgrade-project")
if not query.name:
for template in project.templates.keys():
for template in tuple(project.templates.keys()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, this won't break if they have old conductor files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, this function doesn't touch the conductor file (there are no .save() calls).

Copy link
Contributor

@noam987 noam987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushuk ayushuk merged commit d8b8a6a into master May 18, 2024
8 checks passed
@ayushuk ayushuk deleted the release/3.5.2 branch May 18, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants