Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Resolve Python 3.11.6_1 Enum changes #302

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

BennyBot
Copy link
Member

@BennyBot BennyBot commented Nov 4, 2023

Summary:

Python 3.11.6_1 no longer allows for empty enum classes, this addresses it.
see this: https://fossies.org/diffs/Python/3.11.5_vs_3.11.6/Lib/enum.py-diff.html.

This is a bandaid solution for the problem of our CLI installs sometimes deciding to use user installed version of python instead of the one that comes with the CLI. Either way we should probably do this anyways since it fixes it on new python without breaking it on the older versions. (probably [?] it is currently untested).

Motivation:

VTOW bug report

Test Plan:

  • Make sure uploading doesn't give weird errors on python 3.11.6_1, as well as some version older than that (3.11.5, 3.9.x, etc)

@BennyBot BennyBot changed the title 🐛Add something into BrainFlags 🐛 Resolve Python 3.11.6_1 Enum changes Nov 4, 2023
Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need to test this since it isn't accessed in the code. It's up to you to test if you want or just merge it, I'll approve it anyways so we can get it into the 3.5.0 release.

@ayushuk ayushuk merged commit 26d19b7 into develop Jan 13, 2024
10 checks passed
@ayushuk ayushuk deleted the bugfix/enumclass-python-3-11-6-1 branch January 13, 2024 01:59
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants