Fix base-image CI exiting early when update is needed #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Oct 1, 2024
| @@ -45,6 +45,8 @@ runs: | |||
| # Enable running/building ARM64 images: https://github.com/multiarch/qemu-user-static | |||
| sudo podman run --rm --privileged multiarch/qemu-user-static --reset -p yes | |||
| IMAGES=() | |||
| # Github runs with -e by default, but dnf check-upgrade returns 100 when upgrade needed | |||
| set +e | |||
There was a problem hiding this comment.
Shouldn't we do
if ! podman run --pull=never pulp/${IMAGE}:ci-${ARCH} bash -c "dnf check-upgrade"
then
...
fi
instead?
gerrod3
force-pushed
the
unsete
branch
2 times, most recently
from
278cef0
to
9ec59c5
Compare
|
The compose test was failing because it was trying to pull the tag 3.63 for the web image, but we haven't published that tag yet since our CI was broken yesterday during the release. I changed the code so that it'll pull 'latest' instead of the branch version for PRs and releases on latest so that we should be able to pull something. Now how useful it is to test compose with the multi-process images, I don't know. |
mdellweg
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.