Fix docker-compose add_signing_service script #648
Conversation
| @@ -3,7 +3,7 @@ | |||
| /usr/bin/wait_on_postgres.py | |||
| /usr/bin/wait_on_database_migrations.sh | |||
|
|
|||
| if [ -n "${PULP_SIGNING_KEY_FINGERPRINT}" ]; then | |||
| if [ -n "${PULP_SIGNING_KEY_FINGERPRINT-}" ]; then | |||
There was a problem hiding this comment.
Isn't that:
| if [ -n "${PULP_SIGNING_KEY_FINGERPRINT-}" ]; then | |
| if [ -n "${PULP_SIGNING_KEY_FINGERPRINT:-}" ]; then |
There was a problem hiding this comment.
Adding the colon makes it also a nullity check. Do you think we need to check also if the value is null, since the default I am setting it to is null? (I am actually not sure how null works in bash land)
There was a problem hiding this comment.
Well, I'd say if the variable was not set or set to "" it is safe to assume we cannot configure a signing service from it.
But honestly i didn't know about "-" alone.
But now reading up, i think both produce the same result here, as we replace with "".
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
fixes: #647