Skip to content

Commit

Permalink
Merge pull request #680 from gerrod3/web-tag-fix
Browse files Browse the repository at this point in the history
Fix mislabeled tag in pulp-web publish & simplify compose testing to only pulp-minimal images
  • Loading branch information
gerrod3 authored Oct 16, 2024
2 parents 2b3423a + 4f5a6b2 commit 801dc23
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/actions/publish_images/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ runs:
for registry in ghcr.io docker.io quay.io; do
for image in ${{ inputs.image_names }}; do
for tag in ${{ inputs.tags }}; do
podman manifest create ${registry}/pulp/${image}:${tag} containers-storage:localhost/pulp/${image}:ci-amd64 containers-storage:localhost/pulp/${image}:ci-arm64
podman manifest create ${registry}/pulp/${image}:${tag} containers-storage:localhost/pulp/${image}:ci-arm64 containers-storage:localhost/pulp/${image}:ci-amd64
podman manifest push --all ${registry}/pulp/${image}:${tag} ${registry}/pulp/${image}:${tag}
done
done
Expand Down
24 changes: 3 additions & 21 deletions .github/actions/test_image/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@ runs:
- name: Install httpie and podman-compose
run: |
echo "HTTPIE_CONFIG_DIR=$GITHUB_WORKSPACE/.ci/assets/httpie/" >> $GITHUB_ENV
echo "Working around https://bugs.launchpad.net/ubuntu/+source/libpod/+bug/2024394"
curl -O http://archive.ubuntu.com/ubuntu/pool/universe/g/golang-github-containernetworking-plugins/containernetworking-plugins_1.1.1+ds1-3_amd64.deb
sudo dpkg -i containernetworking-plugins_1.1.1+ds1-3_amd64.deb
# Ubuntu 22.04 has old podman 3.4.4, we need podman-compose==1.0.3 to avoid an
# error with dependency contianers not being detected as running.
# "error generating dependency graph for container"
pip install httpie podman-compose==1.0.3
pip install httpie podman-compose
shell: bash

- name: Test image with upgrade in s6 mode (pulp)
Expand All @@ -46,20 +40,8 @@ runs:
shell: bash

- name: Test Compose up
if: inputs.image_name == 'pulp-minimal' || inputs.image_name == 'galaxy-minimal'
run: |
if [[ "${{ inputs.image_name }}" == "pulp" || "${{ inputs.image_name }}" == "galaxy" ]]; then
FILE="compose.folders.yml"
# We'll pull the web image from a registry since we didn't build it.
if [ "${{ inputs.image_variant }}" == "nightly" ]; then
WEB_TAG="nightly"
else
# This will be the branch we are running on, either latest or version branch
WEB_TAG="${{ github.base_ref || github.ref_name }}"
fi
else
FILE="compose.yml"
WEB_TAG="ci-amd64"
fi
base_image=$(echo ${{ inputs.image_name }} | cut -d '-' -f1)
images/compose/test.sh "${{ inputs.image_name }}:ci-amd64" "${base_image}-web:${WEB_TAG}" $FILE
images/compose/test.sh "${{ inputs.image_name }}:ci-amd64" "${base_image}-web:ci-amd64" "compose.yml"
shell: bash

0 comments on commit 801dc23

Please sign in to comment.