Test cert setup #1053
Merged
Test cert setup #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
test_cert_setup
branch
from
25aa99b
to
e3171af
Compare
mdellweg
force-pushed
the
test_cert_setup
branch
8 times, most recently
from
7e8002c
to
f0ae07b
Compare
mdellweg
force-pushed
the
test_cert_setup
branch
from
f0ae07b
to
5517ba9
Compare
This sets up nginx to accept client certificates and provides a matching client certificate with DN=admin.
mdellweg
force-pushed
the
test_cert_setup
branch
from
5517ba9
to
5e0dc4d
Compare
gerrod3
reviewed
Sep 5, 2024
Comment on lines
+64
to
+67
| python3 "${BASEPATH}/gen_certs.py" -d "${PULP_CLI_TEST_TMPDIR}/settings/certs" | ||
| export PULP_CA_BUNDLE="${PULP_CLI_TEST_TMPDIR}/settings/certs/ca.pem" | ||
| ln -fs server.pem "${PULP_CLI_TEST_TMPDIR}/settings/certs/pulp_webserver.crt" | ||
| ln -fs server.key "${PULP_CLI_TEST_TMPDIR}/settings/certs/pulp_webserver.key" |
There was a problem hiding this comment.
I'm confused on how these links find the right files. I though the server.pem and server.key are being stored in PULP_CLI_TEST_TMPDIR/settings/certs, what directory are the ln commands running from?
There was a problem hiding this comment.
It's confusing yes. But the first parameter is the relative path the link gets, so in the end the files and the links land in the same directory, while the PWD of the ln command can be anything.
| @@ -1,4 +1,3 @@ | |||
| ALLOWED_EXPORT_PATHS = ["/tmp"] | |||
| ORPHAN_PROTECTION_TIME = 0 | |||
There was a problem hiding this comment.
Are we sure this isn't going to break some tests?
There was a problem hiding this comment.
Sure? Well we put it in a loooong time ago as a stop gap. I don't think we do that in the repositories CI anymore.
gerrod3
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.