Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hw: Fix out of bounds array #95

Merged
merged 1 commit into from
Jul 19, 2023
Merged

hw: Fix out of bounds array #95

merged 1 commit into from
Jul 19, 2023

Conversation

alex96295
Copy link
Collaborator

@alex96295 alex96295 commented Jul 19, 2023 •
edited
Loading

Mailboxes are in the same clock and reset domain of the host, and they do not require isolate signals

@alex96295 alex96295 requested a review from micprog July 19, 2023 06:38
@alex96295 alex96295 self-assigned this Jul 19, 2023
@alex96295 alex96295 added the design Wire missing connection, undesired latches, parameter tuning (functionality still correct) label Jul 19, 2023
micprog
micprog approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alex96295 alex96295 merged commit 4f2b4a6 into main Jul 19, 2023
7 checks passed
@micprog micprog deleted the aottaviano/fix-array-bound branch July 21, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micprog micprog micprog approved these changes

@luca-valente luca-valente Awaiting requested review from luca-valente

Assignees

@alex96295 alex96295

Labels
design Wire missing connection, undesired latches, parameter tuning (functionality still correct)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex96295 @micprog