Fix for hard-coded nu-get Newtonsoft usage in C# SDK causing Unity IL2CPP builds to crash #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PluggableLibrary implementations, remove duplicate/non-IJsonPluggableLibrary-based deserialization logic
jakub-grzesiowski
requested review from
mohitpubnub,
Xavrax and
marcin-cebo
as code owners
|
IMPORTANT: Probably best to only review and not merge before 06.04.2024 when I come back since this needs a Unity counterpart anyway |
mohitpubnub
approved these changes
May 6, 2024
| @@ -114,7 +114,7 @@ public SubscribeManager2(PNConfiguration pubnubConfig, IJsonPluggableLibrary jso | |||
| if (!string.IsNullOrEmpty(responseTuple.Item1) && responseTuple.Item2 == null) | |||
| { | |||
| PNStatus status = new PNStatus(null, PNOperationType.PNSubscribeOperation, PNStatusCategory.PNConnectedCategory, channels, channelGroups); | |||
| HandshakeResponse handshakeResponse = JsonConvert.DeserializeObject<HandshakeResponse>(responseTuple.Item1); | |||
| HandshakeResponse handshakeResponse = jsonLibrary.DeserializeToObject<HandshakeResponse>(responseTuple.Item1); | |||
| @@ -14,18 +12,18 @@ public class EmitMessagesHandler : EffectHandler<EmitMessagesInvocation> | |||
| { | |||
| private readonly Dictionary<string, Type> channelTypeMap; | |||
| private readonly Dictionary<string, Type> channelGroupTypeMap; | |||
| private readonly JsonSerializer serializer; | |||
| private readonly IJsonPluggableLibrary jsonPluggableLibrary; | |||
|
@pubnub-release-bot release as v6.20.1.0 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fix hard-coded nu-get Newtonsoft usage in C# SDK causing Unity IL2CPP builds to crash
Fixes issue of Unity SDK not being able to have a fully independent IJsonPluggableLibrary implementation because of direct nu-get Newtonsoft usage in C# SDK (Unity has it's own version that works with IL2CPP builds)