-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:EventEngine #215
Merged
Merged
feat:EventEngine #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PresenceEventEngine and its factory class implementation * PresenceOperation class implementation * Initialise PresenceOperation into SubscribeOperation for triggering PresenceEvent Engine * Subscribe() api to have PresenceOperation initialised conditionally * Added classes for PubnubPCL project * fix: namespace convention for PresenceOperation class * Update UWP.csproj file for new classes reference links * * decoupled wait effect handler from invocation"s interval value * bind effects with States * * `MaintainPresenceState` flag in PubNub configuration. Integration of Unsibscribe api with event engine enabled scenario. Fix state object construction issue for given pubnub instance id. Handling of subsequent Subscribe call in Subscription manager for event engine. removed dummy invocations. Exposed channel/group for subscribe event engine for internal usage. * syntax fix for all.net version compatiblity for empty Array init
* refactor EventEngine source code: * Updated subscribe states. * updated subscribe Effects * Fixed Retry in effect handlers to get configuration from PNConfiguration instance. * Refactored Unsubscribe. * Renamed SubscirbeOperation2 to SubscriptionEndpoint * Miscellaneous minor fixes * fix csproj file for UWP * Revert "fix csproj file for UWP" This reverts commit 7897081. * fix compilation error csproj UWP * removed duplicate entry for include * fix: subscribe event engine workflow * UnsubscribeAllEndpoint added for event Engine * Refactored code for handling unsubscribe in Presence * added UnsubscribeAllEndpoint class * refactored code for receive Effect handler and some code readablility issue addressed * update PCL and UWP * code indentation pubnub.cs * fix: acceptance test build
* * fix subscribe event engine transition for restore, * fixed retry related state context information, * fixed timetoken data type for step definition method param * updated code behind file to latest specs. * Presence event engine accpetance tests * fix: Subsscribe event engine related bug caught during acceptance tests * fix: presence event engine issues identified during acceptance tests * fix: objects v2 acceptance tests key issue --------- Co-authored-by: Serhii Mamontov <[email protected]>
mohitpubnub
commented
Apr 10, 2024
…t event data to intended callback code clean up
…es from MockServerPubnubApi to MockServerPubnubApiPCL
@pubnub-release-bot release as v6.20.0.0 |
marcin-cebo
approved these changes
Apr 18, 2024
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Subscribe and presence operation with event engine support.
Added event engine implementation for subscribe and presence operation.
feat: Support for RetryConfiguration.
Added support for
RetryConfiguration
to configure subscribe request retry.