Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/JSON Serialisation when message decryption failed #202

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Jan 16, 2024

fix: json serialisation failed for custom objects when crypto module is configured.

Fixes issue of getting exception for custom objects in subscription and history when crypto module is configured.

Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -71 to -72

errorCallback.OnResponse(default(T), status);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, I missed this during the previous change ;o?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v6.19.5.0

@mohitpubnub mohitpubnub merged commit 43a3e47 into master Jan 17, 2024
5 checks passed
@mohitpubnub mohitpubnub deleted the CLEN-1780 branch January 17, 2024 08:08
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants