Fix/here_now (#193)

* fix: hereNow with channelGroups only, url * Update CODEOWNERS * Update CODEOWNERS * argument validation for hereNow * PubNub SDK v6.19.0.1 release. * revert b7e1e6b * PubNub SDK v6.19.1.0 release. --------- Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]>
pubnub · Oct 24, 2023 · afa3f16 · afa3f16
1 parent 3f516b0
commit afa3f16
Show file tree

Hide file tree

Showing 8 changed files with 31 additions and 31 deletions.
diff --git a/.pubnub.yml b/.pubnub.yml
@@ -1,8 +1,13 @@
 name: c-sharp
-version: "6.19.0"
+version: "6.19.1"
 schema: 1
 scm: github.com/pubnub/c-sharp
 changelog:
+  - date: 2023-10-24
+    version: v6.19.1
+    changes:
+      - type: bug
+        text: "Fixes issue of getting error when hereNow is called with channelGroups param only."
   - date: 2023-10-16
     version: v6.19.0
     changes:
@@ -741,7 +746,7 @@ features:
     - QUERY-PARAM
 supported-platforms:
   -
-    version: Pubnub 'C#' 6.19.0
+    version: Pubnub 'C#' 6.19.1
     platforms:
       - Windows 10 and up
       - Windows Server 2008 and up
@@ -751,7 +756,7 @@ supported-platforms:
       - .Net Framework 4.5
       - .Net Framework 4.6.1+
   -
-    version: PubnubPCL 'C#' 6.19.0
+    version: PubnubPCL 'C#' 6.19.1
     platforms:
       - Xamarin.Android
       - Xamarin.iOS
@@ -771,7 +776,7 @@ supported-platforms:
       - .Net Core
       - .Net 6.0
   -
-    version: PubnubUWP 'C#' 6.19.0
+    version: PubnubUWP 'C#' 6.19.1
     platforms:
       - Windows Phone 10
       - Universal Windows Apps
@@ -795,7 +800,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: Pubnub
-            location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.0.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.1.0
             requires:
               -
                 name: ".Net"
@@ -1078,7 +1083,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: PubNubPCL
-            location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.0.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.1.0
             requires:
               -
                 name: ".Net Core"
@@ -1437,7 +1442,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: PubnubUWP
-            location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.0.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.1.0
             requires:
               -
                 name: "Universal Windows Platform Development"

diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,7 @@
+v6.19.1 - October 24 2023
+-----------------------------
+- Fixed: fixes issue of getting error when hereNow is called with channelGroups param only.
+
 v6.19.0 - October 16 2023
 -----------------------------
 - Added: add crypto module that allows configure SDK to encrypt and decrypt messages.

diff --git a/src/Api/PubnubApi/Builder/UrlRequestBuilder.cs b/src/Api/PubnubApi/Builder/UrlRequestBuilder.cs
@@ -278,18 +278,18 @@ Uri IUrlRequestBuilder.BuildSignalRequest(string requestMethod, string requestBo
         Uri IUrlRequestBuilder.BuildHereNowRequest(string requestMethod, string requestBody, string[] channels, string[] channelGroups, bool showUUIDList, bool includeUserState, Dictionary<string, object> externalQueryParam)
         {
             PNOperationType currentType = PNOperationType.PNHereNowOperation;
-            string channel = (channels != null && channels.Length > 0) ? string.Join(",", channels.OrderBy(x => x).ToArray()) : "";
+            if ((channels == null || channels.Length == 0) && (channelGroups == null || channelGroups.Length == 0)) {
+                throw new ArgumentException("Please provide Channels or ChannelGroups.");
+            }
+            string channel = (channels != null && channels.Length > 0) ? string.Join(",", channels.OrderBy(x => x).ToArray()) : ",";
 
             List<string> url = new List<string>();
             url.Add("v2");
             url.Add("presence");
             url.Add("sub_key");
             url.Add(pubnubConfig.ContainsKey(pubnubInstanceId) ? pubnubConfig[pubnubInstanceId].SubscribeKey : "");
-            if (!string.IsNullOrEmpty(channel))
-            {
-                url.Add("channel");
-                url.Add(channel);
-            }
+            url.Add("channel");
+            url.Add(channel);
 
             int disableUUID = showUUIDList ? 0 : 1;
             int userState = includeUserState ? 1 : 0;

diff --git a/src/Api/PubnubApi/Properties/AssemblyInfo.cs b/src/Api/PubnubApi/Properties/AssemblyInfo.cs
@@ -11,8 +11,8 @@
 [assembly: AssemblyProduct("Pubnub C# SDK")]
 [assembly: AssemblyCopyright("Copyright ©  2021")]
 [assembly: AssemblyTrademark("")]
-[assembly: AssemblyVersion("6.19.0.0")]
-[assembly: AssemblyFileVersion("6.19.0.0")]
+[assembly: AssemblyVersion("6.19.1.0")]
+[assembly: AssemblyFileVersion("6.19.1.0")]
 // Setting ComVisible to false makes the types in this assembly not visible
 // to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.

diff --git a/src/Api/PubnubApi/PubnubApi.csproj b/src/Api/PubnubApi/PubnubApi.csproj
@@ -14,18 +14,15 @@
 
   <PropertyGroup>
     <PackageId>Pubnub</PackageId>
-    <PackageVersion>6.19.0.0</PackageVersion>
+    <PackageVersion>6.19.1.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Add crypto module that allows configure SDK to encrypt and decrypt messages.
-Improved security of crypto implementation by adding enhanced AES-CBC cryptor.
-Fixes Newtonsoft Json vulnerability with MaxDepth and upgrade to version  for non-PCL.
-Add SubscribeKey validation for subscribe feature.</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixes issue of getting error when hereNow is called with channelGroups param only.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

diff --git a/src/Api/PubnubApiPCL/PubnubApiPCL.csproj b/src/Api/PubnubApiPCL/PubnubApiPCL.csproj
@@ -15,18 +15,15 @@
 
   <PropertyGroup>
     <PackageId>PubnubPCL</PackageId>
-    <PackageVersion>6.19.0.0</PackageVersion>
+    <PackageVersion>6.19.1.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Add crypto module that allows configure SDK to encrypt and decrypt messages.
-Improved security of crypto implementation by adding enhanced AES-CBC cryptor.
-Fixes Newtonsoft Json vulnerability with MaxDepth and upgrade to version  for non-PCL.
-Add SubscribeKey validation for subscribe feature.</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixes issue of getting error when hereNow is called with channelGroups param only.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

diff --git a/src/Api/PubnubApiUWP/PubnubApiUWP.csproj b/src/Api/PubnubApiUWP/PubnubApiUWP.csproj
@@ -16,18 +16,15 @@
 
   <PropertyGroup>
     <PackageId>PubnubUWP</PackageId>
-    <PackageVersion>6.19.0.0</PackageVersion>
+    <PackageVersion>6.19.1.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Add crypto module that allows configure SDK to encrypt and decrypt messages.
-Improved security of crypto implementation by adding enhanced AES-CBC cryptor.
-Fixes Newtonsoft Json vulnerability with MaxDepth and upgrade to version  for non-PCL.
-Add SubscribeKey validation for subscribe feature.</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixes issue of getting error when hereNow is called with channelGroups param only.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

diff --git a/src/Api/PubnubApiUnity/PubnubApiUnity.csproj b/src/Api/PubnubApiUnity/PubnubApiUnity.csproj
@@ -15,7 +15,7 @@
 
   <PropertyGroup>
     <PackageId>PubnubApiUnity</PackageId>
-    <PackageVersion>6.19.0.0</PackageVersion>
+    <PackageVersion>6.19.1.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>