Fix renovate PR of rimraf 5.x #1228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The root cause of base failing is the browserify does not properly parse files in a glob that contain a class with private methods. I am not familiar with browserify. I'm looking for fixes for browserify parsing. |
|
Fixed here #1243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pubkey
This PR contains:
Describe the problem you have without this PR
The renovate PR for rimraf 5.x did not include changes for necessary for rimraf 5.x. Specifically, rimraf no longer uses a default export. In rimraf v4.x, the function returns a Promise. So, util.promisify is not needed.