Drop Python 3.8 support #4452
Merged
Drop Python 3.8 support #4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Sep 16, 2024
jtmedley
reviewed
Oct 9, 2024
| @@ -549,6 +549,7 @@ def main( # noqa: C901 | |||
| """The uncompromising code formatter.""" | |||
| ctx.ensure_object(dict) | |||
|
|
|||
| assert sys.version_info >= (3, 9), "Black requires Python 3.9+" | |||
There was a problem hiding this comment.
Why is this added? This wasn't needed in the __init__.py file for previous minimum versions. Python version requirements are handled by requires-python in pyproject.toml, and that was already correctly changed in this commit.
There was a problem hiding this comment.
It's harmless enough, Black is definitely broken on 3.8, I have dev environments lying around with random Python versions. Is it causing you some issue?
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are manual changes, we can run pyupgrade equivalents in a later PR