Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support Python 3.13, including CI testing and wheel building #4436

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Aug 14, 2024

Enable Python 3.13 testing in the GitHub Action workflows by adding 3.13 jobs to the test matrices.

Python 3.13 is now in release candidate phase and ABI stable.

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

github-actions bot commented Aug 14, 2024

diff-shades reports zero changes comparing this PR (45c9b18) to main (823a7b0).


What is this? | Workflow run | diff-shades documentation

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 14, 2024

Does an internal tooling change like this need a changelog entry?

@JelleZijlstra
Copy link
Collaborator

I think it does; it should say that we now officially support Python 3.13. Could you add that and also add 3.13 to the trove classifiers in pyproject.toml?

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 14, 2024

Something like this?

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 14, 2024

#4427 was needed for full Python 3.13 support, so I included that in this PR.

@EwoutH EwoutH changed the title CI: Add Python 3.13 jobs to test matrices Fully support Python 3.13, including CI testing and wheel building Aug 14, 2024
@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 14, 2024

I think I now have everything for full Python 3.13 support and testing. If I have missed anything, let me know!

@JelleZijlstra
Copy link
Collaborator

Looks like the mypyc wheel build fails on 3.13. There are some open issues on the mypy side for adding 3.13 support. Possibly we could release only a pure-Python wheel on 3.13 for now.

@hauntsaninja
Copy link
Collaborator

We already ship a pure Python wheel, so 3.13 users will just pick it up

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 17, 2024

Looks like it might be a while, shall I update this PR to not build the mypyc 3.13 wheel yet, and that we merge that in a separate PR?

@JelleZijlstra
Copy link
Collaborator

Yes, that sounds good.

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 17, 2024

Updated!

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 26, 2024

Is there anything I still need to do?

Edit: I rebased this branch on the latest main head.

EwoutH and others added 6 commits August 26, 2024 15:13
Enable Python 3.13 testing in the GitHub Action workflows by adding 3.13 jobs to the test matrices.

Python 3.13 is now in release candidate phase and ABI stable.
With cibuildwheel 2.20.0 CPython 3.13 wheels are now built by default - without the CIBW_PRERELEASE_PYTHONS flag. This release includes CPython 3.13.0rc1, which is guaranteed to be ABI compatible with the final release.
Update the "generate wheels matrix" to build Python 3.13 wheels, instead of 3.12, which is now the highest supported version
This commit can be reverted once mypyc support Python 3.13
@JelleZijlstra JelleZijlstra merged commit ac28187 into psf:main Aug 26, 2024
54 checks passed
Typocalypse pushed a commit to Typocalypse/black that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants