-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully support Python 3.13, including CI testing and wheel building #4436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Does an internal tooling change like this need a changelog entry? |
I think it does; it should say that we now officially support Python 3.13. Could you add that and also add 3.13 to the trove classifiers in |
Something like this? |
#4427 was needed for full Python 3.13 support, so I included that in this PR. |
I think I now have everything for full Python 3.13 support and testing. If I have missed anything, let me know! |
Looks like the mypyc wheel build fails on 3.13. There are some open issues on the mypy side for adding 3.13 support. Possibly we could release only a pure-Python wheel on 3.13 for now. |
We already ship a pure Python wheel, so 3.13 users will just pick it up |
Looks like it might be a while, shall I update this PR to not build the mypyc 3.13 wheel yet, and that we merge that in a separate PR? |
Yes, that sounds good. |
Updated! |
Is there anything I still need to do? Edit: I rebased this branch on the latest main head. |
Enable Python 3.13 testing in the GitHub Action workflows by adding 3.13 jobs to the test matrices. Python 3.13 is now in release candidate phase and ABI stable.
for more information, see https://pre-commit.ci
With cibuildwheel 2.20.0 CPython 3.13 wheels are now built by default - without the CIBW_PRERELEASE_PYTHONS flag. This release includes CPython 3.13.0rc1, which is guaranteed to be ABI compatible with the final release.
Update the "generate wheels matrix" to build Python 3.13 wheels, instead of 3.12, which is now the highest supported version
This commit can be reverted once mypyc support Python 3.13
Enable Python 3.13 testing in the GitHub Action workflows by adding 3.13 jobs to the test matrices.
Python 3.13 is now in release candidate phase and ABI stable.