Fix incorrect linenos on fstring tokens with escaped newlines #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this can affect Black itself much (maybe for formatting ranges), but I ran into this with https://github.com/JelleZijlstra/lib2toast
for more information, see https://pre-commit.ci
| if __name__ == "__main__": | ||
| code = sys.stdin.read() | ||
| tokens = get_tokens(code) | ||
| text = f"assert_tokenizes({code!r}, {tokens!r})" |
There was a problem hiding this comment.
consider using the builtin tokenize module for generating tests? that way you don't have to verify the locations before adding the test.
There was a problem hiding this comment.
I'm not sure how compatible exactly are the tokens between Python and blib2to3 though.
There was a problem hiding this comment.
They don't match exactly in all cases (e.g., builtin has an extra encoding token at the beginning). We can try to work towards exact compatibility, but not sure that's necessary.
There was a problem hiding this comment.
Yeah, for now this is good
tusharsadhwani
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this can affect Black itself much (maybe for formatting
ranges), but I ran into this with https://github.com/JelleZijlstra/lib2toast
cc @tusharsadhwani