fix: don't try to format strings inside f-strings #4401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4350 , closes #4365
If a string like
'\''
is inside a double-quoted f-string, likef"{'\''}"
the formatter would break trying to remove the escaped\'
quote.This is because
normalize_string_quotes
looks at the entiref"{'\''}"
input, and the outermost quotes"
, hence determining that the\'
escape is unnecessary.To avoid these cases, we don't try to normalize inner strings inside f-string braces.