Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check excludes before symlink resolution for command line parameters #3987

Closed
wants to merge 4 commits into from
Closed

Check excludes before symlink resolution for command line parameters #3987

wants to merge 4 commits into from

Conversation

sth
Copy link
Contributor

@sth sth commented Oct 27, 2023

Description

This adjusts exclusion checking for command line parameters the same way as #3846 did for other files. Specifically, --force-exclude is now checked before symlink resolution. This way symlink handling is consistent between command line parameters and other collected files.

Fixes #3826.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@sth
Test interaction between --force-exclude and symlinks as cli parameters
ab810bd
@sth
Check excludes before symlink resolution for command line parameters
d534b17 
This adjusts exclusion checking for command line parameters the same way
as psf#3846 did for other files. Specifically, --force-exclude is now
checked before symlink resolution. This way symlink handling is
consistent between command line parameters and other collected files.

Fixes psf#3826.
@sth
Add to CHANGES.md
2ef832d
@sth
Change CHANGES formatting to match CI check
ded8f3d
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (ded8f3d) to main (c369e44).

What is this? | Workflow run | diff-shades documentation

@sth sth marked this pull request as draft October 27, 2023 13:47
@sth
Copy link
Contributor Author

sth commented Oct 27, 2023

The current problem in the test case is probably that the root path went through a resolve() while the source file path didn't. So if there are symlinks or other path changes that get normalized in resolve(), the two kinds of paths might not match anymore, causing errors in relative_to().

@sth
Copy link
Contributor Author

sth commented Nov 7, 2023

This is obsolete now, #4015 fixed the problems 🎉

@sth sth closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force Exclude does not work with symlinks
1 participant
@sth