-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matching of absolute paths in --include
#3976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and opening a PR! I think we should use root_relative_path
on L396 , so we apply include logic before symlink resolution
I agree it makes sense to check include and exclude against the same type of path and not use resolved symlinks for one and unresolved symlinks for the other. It now checks the path with unresolved symlinks against includes and excludes and the symlink target is not checked this way (but it is still checked if is under the root dir). I also added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
This is a fix for #3975.
It modifies
normalized_path
in the way it was done before #3846, so that the check for included files still matches the same files.Checklist - did you ...
CHANGES.md
if necessary?