Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export black.Mode #3875

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Re-export black.Mode #3875

merged 4 commits into from
Sep 10, 2023

Conversation

JelleZijlstra
Copy link
Collaborator

And test that certain common external use cases (taken from https://grep.app/search?q=black.Mode&case=true) keep working.

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Sep 10, 2023
@JelleZijlstra
Copy link
Collaborator Author

Motivation is that otherwise mypyc on 3.12 (for unclear reasons) doesn't allow you to use black.Mode, as discussed in #3867 (comment)

@github-actions
Copy link

diff-shades reports zero changes comparing this PR (9eac0de) to main (c83ad6c).


What is this? | Workflow run | diff-shades documentation

@hauntsaninja hauntsaninja merged commit f791745 into psf:main Sep 10, 2023
29 checks passed
@cdce8p
Copy link
Contributor

cdce8p commented Sep 11, 2023

I'm still seeing the error for Python 3.12, at least with cibuildwheel, which still uses 3.12.0rc0. Can't reproduce it locally with 3.12.0rc1 though 🤔

AttributeError: module 'black' has no attribute 'Mode'. Did you mean: 'mode'?

@JelleZijlstra JelleZijlstra deleted the exportmode branch September 11, 2023 02:24
@JelleZijlstra JelleZijlstra restored the exportmode branch September 10, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants