Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in target-version param wrongly used in plural #3817

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix typo in target-version param wrongly used in plural #3817

merged 1 commit into from
Jul 27, 2023

Conversation

zyv
Copy link
Contributor

@zyv zyv commented Jul 27, 2023

Description

In the code and tests the parameter is called target-version, not target-versionS. I think it's not good to have this typo here as it present a copy & paste risk of confusion.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix this!

@cooperlees cooperlees merged commit d9d0a02 into psf:main Jul 27, 2023
7 of 8 checks passed
@zyv
Copy link
Contributor Author

zyv commented Jul 27, 2023

Thank you for quick processing and maintaining the tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants