Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elb): add new check elb_desync_mitigation_mode #5500

Conversation

MarioRgzLpz
Copy link
Member

Context

Add a new check to ensure Classic Load Balancers are configured with either the defensive or strictest desync mitigation mode to prevent HTTP desynchronization issues. This control fails if the desync mitigation mode does not use one of these modes.

HTTP desync vulnerabilities can lead to serious security risks like request smuggling, credential hijacking, and unauthorized command execution. Enabling defensive or strictest desync mitigation modes helps protect applications from these risks by safeguarding against potential desynchronization attacks.

Description

Changed elb service to add a new attribute desync_mitigation_mode to LoadBalancer model. Added a new check elb_desync_mitigation_mode with respective unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarioRgzLpz MarioRgzLpz requested review from a team as code owners October 22, 2024 11:37
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (ffa29f2) to head (43d454c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5500      +/-   ##
==========================================
+ Coverage   89.58%   89.62%   +0.03%     
==========================================
  Files        1073     1075       +2     
  Lines       33237    33287      +50     
==========================================
+ Hits        29777    29832      +55     
+ Misses       3460     3455       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit f36d23c into master Oct 22, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-4968-ensure-classic-load-balancer-is-configured-with-defensive-or-strictest-desync-mitigation-mode branch October 22, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants