Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinesis): add missing init file #5490

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Oct 21, 2024

Context

Missing init file in Kinesis was producing a bug when listing checks.

Description

Add missing files.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 21, 2024 15:16
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (415c319) to head (fd873c6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5490      +/-   ##
==========================================
- Coverage   89.57%   89.55%   -0.03%     
==========================================
  Files        1068     1068              
  Lines       33109    33109              
==========================================
- Hits        29658    29650       -8     
- Misses       3451     3459       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @puchy22 ⚾ !

@sergargar sergargar merged commit 2ef9e27 into master Oct 21, 2024
10 of 11 checks passed
@sergargar sergargar deleted the PRWLR-5100-add-missing-init-for-kinesis-service branch October 21, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants