Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mq): add new check mq_broker_logging_enabled #5483

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

HugoPBrito
Copy link
Member

Context

Amazon MQ ActiveMQ brokers can stream audit logs to Amazon CloudWatch Logs to provide better visibility into security events and broker activities. Streaming logs to CloudWatch allows for the creation of alarms and metrics to monitor for suspicious activity or operational issues, enhancing security and compliance.

Description

This check ensures that an Amazon MQ ActiveMQ broker is streaming audit logs to Amazon CloudWatch Logs. The check will fail if the broker is not configured to stream these logs.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners October 21, 2024 11:39
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (64fb823) to head (dfaf5ec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5483      +/-   ##
==========================================
- Coverage   89.70%   89.69%   -0.01%     
==========================================
  Files        1085     1086       +1     
  Lines       33517    33545      +28     
==========================================
+ Hits        30065    30087      +22     
- Misses       3452     3458       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review my comments.

@sergargar sergargar self-requested a review October 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants