-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mq): add new check mq_broker_logging_enabled
#5483
Open
HugoPBrito
wants to merge
7
commits into
master
Choose a base branch
from
PRWLR-4543-active-mq-brokers-should-stream-audit-logs-to-cloud-watch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(mq): add new check mq_broker_logging_enabled
#5483
HugoPBrito
wants to merge
7
commits into
master
from
PRWLR-4543-active-mq-brokers-should-stream-audit-logs-to-cloud-watch
+358
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only ActiveMQ brokers will generate findings.
github-actions
bot
added
the
provider/aws
Issues/PRs related with the AWS provider
label
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5483 +/- ##
==========================================
- Coverage 89.70% 89.69% -0.01%
==========================================
Files 1085 1086 +1
Lines 33517 33545 +28
==========================================
+ Hits 30065 30087 +22
- Misses 3452 3458 +6 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Oct 24, 2024
sergargar
reviewed
Oct 24, 2024
prowler/providers/aws/services/mq/mq_broker_logging_enabled/mq_broker_logging_enabled.py
Outdated
Show resolved
Hide resolved
sergargar
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, review my comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Amazon MQ ActiveMQ brokers
can stream audit logs to AmazonCloudWatch Logs
to provide better visibility into security events and broker activities. Streaming logs toCloudWatch
allows for the creation of alarms and metrics to monitor for suspicious activity or operational issues, enhancing security and compliance.Description
This check ensures that an
Amazon MQ ActiveMQ broker
is streaming audit logs to AmazonCloudWatch Logs
. The check will fail if the broker is not configured to stream these logs.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.