-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam): add new check iam_policy_cloudshell_admin_not_attached
#5437
Merged
sergargar
merged 6 commits into
master
from
PRWLR-4537-iam-identities-should-not-have-the-aws-cloud-shell-full-access-policy-attached
Oct 21, 2024
Merged
feat(iam): add new check iam_policy_cloudshell_admin_not_attached
#5437
sergargar
merged 6 commits into
master
from
PRWLR-4537-iam-identities-should-not-have-the-aws-cloud-shell-full-access-policy-attached
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a method to describe every user,group and role that use cloudshell policy and test for the method
github-actions
bot
added
the
provider/aws
Issues/PRs related with the AWS provider
label
Oct 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5437 +/- ##
==========================================
+ Coverage 89.21% 89.57% +0.36%
==========================================
Files 1044 1067 +23
Lines 32225 33080 +855
==========================================
+ Hits 28750 29633 +883
+ Misses 3475 3447 -28 ☔ View full report in Codecov by Sentry. |
sergargar
changed the title
feat(iam): add new check
feat(iam): add new check Oct 17, 2024
iam_cloudshell_admin_policy_not_attached
iam_policy_cloudshell_admin_not_attached
sergargar
reviewed
Oct 17, 2024
..._policy_cloudshell_admin_not_attached/iam_policy_cloudshell_admin_not_attached.metadata.json
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Oct 17, 2024
sergargar
approved these changes
Oct 21, 2024
sergargar
deleted the
PRWLR-4537-iam-identities-should-not-have-the-aws-cloud-shell-full-access-policy-attached
branch
October 21, 2024 14:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a new check to ensure IAM identities (users, roles, or groups) don't have the AWS managed policy
AWSCloudShellFullAccess
attached. The control fails if this policy is present.AWSCloudShellFullAccess
provides full access to AWS CloudShell, including file upload/download capabilities and sudo permissions, which can pose security risks. Adhere to the principle of least privilege and avoid attaching this broad policy.Description
Added new check
iam_cloudshell_admin_policy_not_attached
with respective unit tests. Added new attributeentities_attached_to_cloudshell_policy
with method_list_entities_for_policy
and a test for the method.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.