Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Enable pubsub #53

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Proposal: Enable pubsub #53

wants to merge 9 commits into from

Conversation

Gozala
Copy link

@Gozala Gozala commented Feb 19, 2021

No description provided.

proposals/pubsub.md Outdated Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved
Co-authored-by: Joel Thorstensson <[email protected]>
proposals/pubsub.md Outdated Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved
Co-authored-by: Marcin Rataj <[email protected]>
proposals/pubsub.md Show resolved Hide resolved
proposals/pubsub.md Show resolved Hide resolved
proposals/pubsub.md Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved

- Small to Medium

> I am not really qualified to answer this question. If we find overhead reasonable, enabling it should be metter of switching defaults.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be more clear to list out how many dev effort weeks would take for each step listed in the plan of attack including our guess for adding any necessary metrics, analyzing results, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aschmahmann @Stebalien are probably in better position to do educated guesses here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't. Unfortunately, this is Small to Large because it depends on whether the solution is "flip a switch" or "fix pubsub".

proposals/pubsub.md Outdated Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved
proposals/pubsub.md Outdated Show resolved Hide resolved
@mikeal
Copy link
Contributor

mikeal commented Mar 24, 2021

There’s a lot of comments since the last update. @Gozala is this in a state where we should consider it for 👍👎 or do you need more time to iterate on the proposal.
?

@momack2
Copy link
Contributor

momack2 commented Mar 24, 2021

@marten-seemann & @mxinden - I could see this being a good task for one of you or a devgrant to a go-libp2p contributor you mentor. Do you foresee having bandwidth or knowledge to help with this?

proposals/pubsub.md Outdated Show resolved Hide resolved
@Gozala
Copy link
Author

Gozala commented Mar 24, 2021

There’s a lot of comments since the last update. @Gozala is this in a state where we should consider it for 👍👎 or do you need more time to iterate on the proposal.
?

Applied suggested changes, and marked all but one as resolved. Remaining one is about estimating this work, which I don't find myself to be qualified to answer and is awaiting on @Stebalien and @aschmahmann.

I think it's ready to be voted on.

@mxinden
Copy link

mxinden commented Mar 26, 2021

@marten-seemann & @mxinden - I could see this being a good task for one of you or a devgrant to a go-libp2p contributor you mentor. Do you foresee having bandwidth or knowledge to help with this?

Happy to be involved from the general libp2p side. I don't think I am of much help on the go-libp2p and go-ipfs specific changes.

@mxinden
Copy link

mxinden commented Mar 26, 2021

Applied suggested changes, and marked all but one as resolved. Remaining one is about estimating this work, which I don't find myself to be qualified to answer and is awaiting on @Stebalien and @aschmahmann.

Crossreferencing @Stebalien reply above:

We can't. Unfortunately, this is Small to Large because it depends on whether the solution is "flip a switch" or "fix pubsub".

#53 (comment)

Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.