-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Enable pubsub #53
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Joel Thorstensson <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
|
||
- Small to Medium | ||
|
||
> I am not really qualified to answer this question. If we find overhead reasonable, enabling it should be metter of switching defaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be more clear to list out how many dev effort weeks would take for each step listed in the plan of attack including our guess for adding any necessary metrics, analyzing results, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aschmahmann @Stebalien are probably in better position to do educated guesses here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't. Unfortunately, this is Small to Large because it depends on whether the solution is "flip a switch" or "fix pubsub".
There’s a lot of comments since the last update. @Gozala is this in a state where we should consider it for 👍👎 or do you need more time to iterate on the proposal. |
@marten-seemann & @mxinden - I could see this being a good task for one of you or a devgrant to a go-libp2p contributor you mentor. Do you foresee having bandwidth or knowledge to help with this? |
Co-authored-by: MollyM <[email protected]>
Applied suggested changes, and marked all but one as resolved. Remaining one is about estimating this work, which I don't find myself to be qualified to answer and is awaiting on @Stebalien and @aschmahmann. I think it's ready to be voted on. |
Happy to be involved from the general libp2p side. I don't think I am of much help on the go-libp2p and go-ipfs specific changes. |
Crossreferencing @Stebalien reply above:
|
Co-authored-by: Marcin Rataj <[email protected]>
No description provided.