Fix compatibility when SIGINT handler is installed by non-Python #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a native (Rust, C) program installs SIGINT handler and calls into Python, `signal.getsignal` can return `None`, which is not a valid value for the 2nd parameter of `signal.signal`. Fix it by checking `None` explicitly.
quark-zju
referenced
this pull request
Apr 9, 2024
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Apr 9, 2024
Summary:
Without this, prompt-toolkit (used by IPython) will crash at `_restore_sigint_from_ctypes`:
sigint = signal.getsignal(signal.SIGINT) # None, since the SIGINT handler is not installed by Python
signal.signal(signal.SIGINT, sigint) # TypeError: signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object
See prompt-toolkit/python-prompt-toolkit@6a24c99
Upstream fix: prompt-toolkit/python-prompt-toolkit#1865
Reviewed By: zzl0
Differential Revision: D55900919
fbshipit-source-id: 1a5a4fa79175fdbd0ea63e0ca4fbabe2138b6c25
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a native (Rust, C) program installs SIGINT handler and calls into Python,
signal.getsignalcan returnNone, which is not a valid value for the 2nd parameter ofsignal.signal. Fix it by checkingNoneexplicitly.