Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "If x is a promise" to something clearer. #241

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change "If x is a promise" to something clearer. #241

wants to merge 4 commits into from

Commits on Oct 27, 2016

  1. Change "If x is a promise" to something clearer. 

    Also added some more words of clarification of intent to footnote 3.4,
loosely based on discussion with ForbesLindesay.
Closes promises-aplus#240.
    @donhatch
    donhatch committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    47976a9 View commit details
    Browse the repository at this point in the history

  2. Further clarification of footnote 3.4. 

    Mention `x instanceof Promise` as an example of the kind of check
being suggested.  This is a further improvement for promises-aplus#240.
    @donhatch
    donhatch committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    658d9bb View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2016

  1. Change "(Optional)" to "(Recommended)" 

    More polishing for promises-aplus#240: implementations SHOULD (not MAY) optimize the case
when x is known to be a promise, per discussion with @bergus.
    @donhatch
    donhatch committed Oct 28, 2016
    Configuration menu
    Copy the full SHA
    449cedb View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2016

  1. Rephrase footnote 3.4 as suggested in review.

    @donhatch
    donhatch committed Oct 31, 2016
    Configuration menu
    Copy the full SHA
    6515b8e View commit details
    Browse the repository at this point in the history