Remove Debug Menu on Tournament Mode and re-enable the latter. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e value to 0x87 when opened
JLaferri
reviewed
Jan 26, 2022
| @@ -10,8 +10,8 @@ bne CLEAR | |||
|
|
|||
| # Check force bool | |||
| lbz r3, OFST_R13_FORCE_MENU_CLEAR(r13) | |||
| cmpwi r3, 0 | |||
| bne CLEAR | |||
| cmpwi r3, 1 | |||
There was a problem hiding this comment.
Do we know what this value is for? Maybe we should use a different r13 offset for FORCE_MENU_CLEAR instead?
There was a problem hiding this comment.
Its not clear to what id being used for exactly.
I just know that after you leave tournament mode it is not reset.
But it is always updated when you open up tournament mode. Its safe to use it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes