[PR] Make CPU init robust to bad stage skins #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resyncs the RNG seed prior to initializing the players (after the stage has been initialized). There is a CPU logic counter that gets initialized via an RNG call around
800a123c. If that counter gets initialized differently on two clients, Nana's logic will periodically differ for the duration of the game, potentially causing desyncs.I don't really love this code as it creates a decent amount of coupling between playback and online. If say for example the RNG seed location is moved to a different offset in the playback buffer, any replay that still has the old dynamic code will no longer fetch the correct seed and would desync if resync was off.