chore: Replaced apt with apt-get #804
Conversation
prakrit55
requested review from
jeremyrickard,
sozercan and
ashnamehrotra
as code owners
|
@ashnamehrotra, can you check it once, if it is okay |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 18 18
Lines 1714 1714
=======================================
Hits 813 813
Misses 843 843
Partials 58 58 ☔ View full report in Codecov by Sentry. |
prakrit55
force-pushed
the
pr/apt-aptget
branch
from
6eae7e1
to
db4fbbc
Compare
| } else { | ||
| // if updates is not specified, update all packages | ||
| installCmd = `sh -c "output=$(apt upgrade -y && apt clean -y && apt autoremove 2>&1); if [ $? -ne 0 ]; then echo "$output" >>error_log.txt; fi"` | ||
| installCmd = `sh -c "output=$(apt-get upgrade -y && apt-get clean -y && apt-get autoremove 2>&1); if [ $? -ne 0 ]; then echo "$output" >>error_log.txt; fi"` |
There was a problem hiding this comment.
it seems like this command is not downloading the packages, resulting in the error for the test cases with no report
There was a problem hiding this comment.
@ashnamehrotra, could you check it once, and this too
There was a problem hiding this comment.
it looks like results manifest file is not found, so the packages are not found/downloaded correctly. There is also a log output line 2: packages.txt: No such file or directory. Would you be able to run the apt-get commands manually in a container to see if they are working as expected?
prakrit55
force-pushed
the
pr/apt-aptget
branch
from
db4fbbc
to
1ae874b
Compare
pkg/pkgmgr/dpkg.go
Outdated
| @@ -411,7 +411,7 @@ func (dm *dpkgManager) unpackAndMergeUpdates(ctx context.Context, updates unvers | |||
| while IFS=':' read -r package version; do | |||
| pkg_name=$(echo "$package" | sed 's/^"\(.*\)"$/\1/') | |||
| pkg_version=$(echo "$version" | sed 's/^"\(.*\)"$/\1/') | |||
| latest_version=$(apt show $pkg_name 2>/dev/null | awk -F ': ' '/Version:/{print $2}') | |||
| latest_version=$(apt-get show $pkg_name 2>/dev/null | awk -F ': ' '/Version:/{print $2}') | |||
There was a problem hiding this comment.
apt-get show is not a valid command
website/docs/faq.md
Outdated
| @@ -43,7 +43,7 @@ Experimental: This feature might change without preserving backwards compatibili | |||
|
|
|||
| ::: | |||
|
|
|||
| Copa does not support replacing the repositories in the package managers with alternatives. Images must already use the intended package repositories. For example, for debian, updating `/etc/apt/sources.list` from `http://archive.ubuntu.com/ubuntu/` to a mirror, such as `https://mirrors.wikimedia.org/ubuntu/`. | |||
| Copa does not support replacing the repositories in the package managers with alternatives. Images must already use the intended package repositories. For example, for debian, updating `/etc/apt-get/sources.list` from `http://archive.ubuntu.com/ubuntu/` to a mirror, such as `https://mirrors.wikimedia.org/ubuntu/`. | |||
pkg/pkgmgr/dpkg.go
Outdated
| @@ -24,7 +24,7 @@ const ( | |||
| dpkgLibPath = "/var/lib/dpkg" | |||
| dpkgStatusPath = dpkgLibPath + "/status" | |||
| dpkgStatusFolder = dpkgLibPath + "/status.d" | |||
| dpkgDownloadPath = "/var/cache/apt/archives" | |||
| dpkgDownloadPath = "/var/cache/apt-get/archives" | |||
There was a problem hiding this comment.
/var/cache/apt-get is not a valid dir
please make sure these exist before find and replace
|
@prakrit55 looks like there's a lint issue |
there are some other instances of apt in the docs, let me cover those too |
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
prakrit55
force-pushed
the
pr/apt-aptget
branch
from
6a7d018
to
01e4f01
Compare
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #787