Adding SQL Triggers that check for undefined types in Custom XML #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhchandw
force-pushed
the
task/ZAPP-1259/undefinedTypeWarning
branch
from
a022004
to
4ac12b8
Compare
dhchandw
force-pushed
the
task/ZAPP-1259/undefinedTypeWarning
branch
from
4ac12b8
to
09e3a60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 66.70% 66.76% +0.06%
==========================================
Files 193 193
Lines 20853 20996 +143
Branches 4573 4613 +40
==========================================
+ Hits 13911 14019 +108
- Misses 6942 6977 +35 ☔ View full report in Codecov by Sentry. |
…nd arguments and event fields for a custom XML when inserted into a session. Add session notice as required Added relevant tests Corrected typo in package.json
dhchandw
force-pushed
the
task/ZAPP-1259/undefinedTypeWarning
branch
from
09e3a60
to
cfe29fe
Compare
brdandu
approved these changes
Oct 21, 2024
| sessionNotif.some( | ||
| (notif) => | ||
| notif.type === 'ERROR' && | ||
| notif.message.includes('Undefined Data Type') && |
There was a problem hiding this comment.
intentional errors in my custom XML with bad data type
| sessionNotif.some( | ||
| (notif) => | ||
| notif.type === 'ERROR' && | ||
| notif.message.includes('Undefined Data Type') && |
There was a problem hiding this comment.
intentional errors in my custom XML with bad data type
| SELECT | ||
| 1 | ||
| FROM | ||
| SESSION_PACKAGE spk |
There was a problem hiding this comment.
Maintain consistency with the uppercase in spk, p, etc.
ethanzhouyc
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SQL Triggers that check for undefined types in attributes ,command arguments and event fields for a custom XML when inserted into a session. Add session notice as required
Added relevant tests
Corrected typo in package.json