TC-OPCREDS-3.4: Automate #33541
Open
TC-OPCREDS-3.4: Automate #33541
+254
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33541: Size comparison from 9b6bb5b to 65c76cf Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33541: Size comparison from 2005be9 to 64c0cdf Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
cecille
reviewed
Jul 16, 2024
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #33541: Size comparison from 10531e1 to ee0e41c Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33541: Size comparison from 9ee0499 to 9b14683 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Oct 22, 2024
| # for details about the block below. | ||
| # | ||
| # === BEGIN CI TEST ARGUMENTS === | ||
| # test-runner-runs: run1 |
There was a problem hiding this comment.
This will need to be swapped over to use the yaml style. See new tests.
| return " UpdateNOC-Error Condition [DUT-Server]" | ||
|
|
||
| def steps_TC_OPCREDS_3_4(self): | ||
| return [TestStep(0, "Preconditions"), |
There was a problem hiding this comment.
I don't think this test has preconditions.
Suggested change
| return [TestStep(0, "Preconditions"), |
|
|
||
| @async_test_body | ||
| async def test_TC_OPCREDS_3_4(self): | ||
| self.step(0) |
There was a problem hiding this comment.
Suggested change
| self.step(0) |
|
|
||
| def steps_TC_OPCREDS_3_4(self): | ||
| return [TestStep(0, "Preconditions"), | ||
| TestStep(1, "TH1 fully commissions the DUT"), |
There was a problem hiding this comment.
Suggested change
| TestStep(1, "TH1 fully commissions the DUT"), | |
| TestStep(1, "TH1 fully commissions the DUT", is_commissioning=True), |
| def steps_TC_OPCREDS_3_4(self): | ||
| return [TestStep(0, "Preconditions"), | ||
| TestStep(1, "TH1 fully commissions the DUT"), | ||
| TestStep(2, "TH1 reads the NOCs attribute from the Node Operational Credentials cluster using a fabric-filtered read"), |
There was a problem hiding this comment.
Would you mind adding the expected outcomes to these test steps as well?
| except InteractionModelError as e: | ||
| asserts.assert_equal(e.status, Status.ConstraintError, "Failure status returned from UpdateNOC") | ||
|
|
||
| cmd = Clusters.GeneralCommissioning.Commands.ArmFailSafe(0) |
There was a problem hiding this comment.
Once that test plan change lands, the step numbers here will need to be updated. I'll get Raju to review once he gets back from vacation.
|
|
||
| self.step(12) | ||
| th1_ca_new = self.certificate_authority_manager.NewCertificateAuthority() | ||
| th1_fabric_admin_new = th1_ca_new.NewFabricAdmin(vendorId=0xFFF1, fabricId=1) |
There was a problem hiding this comment.
I think you might be using the same fabric id as the original. Instead, can you get the fabric ID from matter_test_config and increment it? self.matter_test_config.fabric_id
| "NOCResponse with the StatusCode InvalidNOC") | ||
|
|
||
| self.step(15) | ||
| cmd = opcreds |
There was a problem hiding this comment.
Suggested change
| cmd = opcreds |
| resp = await self.openCommissioningWindow(self.default_controller, self.dut_node_id) | ||
|
|
||
| self.step(23) | ||
| # self.FindAndEstablishPase(dev_ctrl=th1_new_fabric_ctrl, longDiscriminator=resp.randomDiscriminator, |
There was a problem hiding this comment.
can these comments be removed now?
|
|
||
| self.step(25) | ||
| new_noc_chain = await self.default_controller.IssueNOCChain(csr_pase, self.dut_node_id) | ||
| # cmd = opcreds.Commands.AddTrustedRootCertificate(trusted_root_original) |
There was a problem hiding this comment.
same, these can be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TC-OPCREDS-3.4 - Automate