Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a user guide in the README #57

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Add a user guide in the README #57

merged 4 commits into from
Dec 12, 2023

Conversation

ChihChengLiang
Copy link
Contributor

Problems to solve

  • Users were unaware of the aggregated proof example.
  • Users were unaware of other repositories and didn't know which one to use in their project.

We further explain the nuances and features of the project in this README.

han0110
han0110 reviewed Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this! Just a nitpick.

README.md Outdated Show resolved Hide resolved
@ChihChengLiang
Copy link
Contributor Author

@han0110 I've addressed the feedback and added the proof aggregation part.

han0110
han0110 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for upgrading the doc!

@ChihChengLiang ChihChengLiang merged commit c400ffc into main Dec 12, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@han0110 han0110 han0110 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChihChengLiang @han0110