Update resolvconf in shell platform #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritunl-client currently only updates resolvconf/systemd-resolve in graphical mode. Add support to the shell platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pritunl-clientcurrently only updates resolvconf/systemd-resolve in graphical mode. This PR contains proof-of-content support for the shell platform.Note that this duplicates logic from
__main__.py, which is suboptimal. I'm not super familiar with the structure of this package, and don't see a good place to migrate the common code to that doesn't introduce a new module.I'm also not sure what the purpose of these arguments passed to OpenVPN are, and seeing as they aren't passed in the existing shell platform I omitted them. They might need to be re-introduced.