-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add groq api and model options #108
Conversation
stop=stop_after_attempt(3), | ||
retry=retry_if_not_exception_type((CostLimitExceededError, RuntimeError)), | ||
) | ||
def query(self, history: list[dict[str, str]]) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How similar is this and history_to_messages
to the OpenaAIModel
class? Because if that's just exactly the same, let's just subclass from there to cut down on duplicity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the same since I'm using the OpenAI() client because Groq is design to be compatible with OpenAi.
https://console.groq.com/docs/openai
I agree. I have no particular preference whether you want to approve #108 or PR #134. In fact, PR #108 seems to have a better separation of concern than the minimal surgical changes proposed by my PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 65.51% 65.09% -0.43%
==========================================
Files 16 16
Lines 2117 2140 +23
==========================================
+ Hits 1387 1393 +6
- Misses 730 747 +17 ☔ View full report in Codecov by Sentry. |
I think groq currently is one of the most interesting options for API-based agents. It's not only the fastest (by far), but also the cheapest, at running many models, including Llama 3. Would love to see it supported in SWE-agent! |
hi! just a couple of adds:
|
Apologies letting this PR hang for such a long time. Part of the reason is that But let me come back with a concrete plan later this week! |
Closing because we should use litellm to support more models (#64 ) |
What does this implement
get free API key here: https://console.groq.com/keys
use as usual by naming the groq model in the command: