Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 7329 #7360

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for Issue 7329 #7360

wants to merge 4 commits into from

Conversation

Nickog13
Copy link

@Nickog13 Nickog13 commented Oct 19, 2024

Fix #7329

This pull request should fix issue #7329 by adding RowBase.getProps to the mergeProps call.
I have also added changes due to two build issues that I have encountered:

  • I also have adjusted few reassignments that are made to constant variables, which failed the build.
  • For a few ts interfaces I got build errors like this: "Type 'ToggleEvent is missing the following properties from type 'FieldSetToggleEvent': originalEvent, value" - Are those currently present in the master branch code base? I got rid of those build errors only for now by adding onToggle to Omit. As I am not very familiar with the prime react code base, I was not sure how to fix this correctly. Would appreciate any hint/help how to fix this in the correct way.

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2024 9:43am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2024 9:43am

@melloware
Copy link
Member

Weird I am not seeing the OnToggle errors you are seeing we do a ts-check on the build of every PR?

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 19, 2024
@melloware
Copy link
Member

For example the build runs npm run type:check

@Nickog13
Copy link
Author

That's weird then: When I clone the current repository and execute the command from above, I am instantly getting the error

@melloware
Copy link
Member

let me check

@melloware
Copy link
Member

C:\dev\primetek\primereact>npm run type:check

> [email protected] type:check
> tsc -p ./api-scripts/tsconfig.json


C:\dev\primetek\primereact>

That is what happens when I run from Main right now?

@Nickog13
Copy link
Author

I think I had a version mismatch with next. I had already installed next 14.2.15 before cloning and my IDE changed the package.json versions without letting me know...
Sorry for the confusion. When reverting back to the version used in main 12.3.4, I don't have the errors.

@melloware
Copy link
Member

OK can you revert all those changes then? I think this PR gets a lot smaller 😄

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all unnecessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row component does not receive className and style property
2 participants