콘텐츠, 크리에이터 목록이 비어있는 경우 처리 #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rjsduf0503
approved these changes
Jun 5, 2023
| @@ -8,7 +8,20 @@ const CardList = ({ | |||
| type: 'creator' | 'content'; | |||
| children: ReactNode; | |||
| }) => { | |||
| return <div className={style.listContainer({ type: type })}>{children}</div>; | |||
| const hasContents = Children.toArray(children).length !== 1 ? true : false; | |||
There was a problem hiding this comment.
이 부분
const hasContents = Children.toArray(children).length !== 1;이렇게 변경하면 더 깔끔할 것 같아요~~
| return ( | ||
| <> | ||
| {hasContents ? ( | ||
| <div className={style.listContainer({ type: type })}>{children}</div> |
There was a problem hiding this comment.
key value 같으니 type만 적어도 무방할 것 같습니다~~ ㅎㅎ
Comment on lines
+19
to
+20
| ? `콘텐츠가 존재하지 않습니다.` | ||
| : `크리에이터가 존재하지 않습니다`} |
There was a problem hiding this comment.
통일성을 위해 변수를 사용하지 않으니 백틱(`)이 아닌 작은 따옴표(')로 변경하면 깔끔할 것 같아요~~
dmswl98
approved these changes
Jun 5, 2023
Comment on lines
+62
to
+64
| if (!getContents) { | ||
| return <Spinner size="huge" />; | ||
| } |
There was a problem hiding this comment.
스피너 굿굿 나중에 에러 바운더리랑 서스펜스도 도입하면 좋을듯~~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 이슈 번호
close #302
📖 작업 내용
✅ PR 포인트
📸 스크린샷