Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded file support for Prawn documents #1214

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

dvdalilue
Copy link

Depends on pdf-core PR 47

This PR defines a new module that allows attaching files (or data) into the generated documents. The module relies on two classes, each one describes a pdf object needed to embed files, the Filespec and EmbeddedFile objects.

The tests and documentation are missing but I'm working on the second one while updating the pdf-core PR 47 with some tests. Then I'll focus on this PR more deeply.

@gettalong
Copy link
Member

Okay, I think there is nothing to do here for the time being without the rest of the functionality as per the comments.

Copy link
Member

@pointlessone pointlessone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love some tests.

lib/prawn/embedded_files.rb Outdated Show resolved Hide resolved
lib/prawn/embedded_files.rb Show resolved Hide resolved
lib/prawn/embedded_files/embedded_file.rb Outdated Show resolved Hide resolved
lib/prawn/embedded_files/filespec.rb Outdated Show resolved Hide resolved
lib/prawn/embedded_files/filespec.rb Outdated Show resolved Hide resolved
lib/prawn/embedded_files/embedded_file.rb Outdated Show resolved Hide resolved
@pointlessone
Copy link
Member

Thank you for your contribution. This is a great start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants