Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore!: Drop python 3.8. Add python 3.13 #1711

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 1, 2024

Requires actions/python-versions#308

Python 3.13 has been delayed until 2024-10-07

* main:
  tests(sidebar): Add tests for sidebar (#1715)
  tests(accordion): Add kitchensink tests for accordion (#1710)
  tests(bug): Use locator instead of element handles (#1716)
  tests(deploys): Move import from htmltools into code to help with debugging deploys (#1718)
  build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing (#1717)
  feat: support DataFrames via narwhals (#1570)
  Adds Deploy to Connect Cloud buttons to app READMEs (#1709)
@schloerke
Copy link
Collaborator Author

greenlet is having trouble compiling. Will wait until there is an official 3.13 release. Not too worried as we do not have compiled code.

@schloerke
Copy link
Collaborator Author

greenlet==3.0.3 is required by playwright v1.47.0. As of this comment v1.47.0 is the latest version on PyPI.

microsoft/playwright-python#2589 has been merged to main two days ago adding python 3.13 support and updating greenlet to a python 3.13 compatible version.

This dependency hell is frustrating to deal with as it is out of our control. 🔔 **shame.png

@schloerke
Copy link
Collaborator Author

Getting past playwright, we hit tokenizers failure to build. Related GitHub Issue: huggingface/tokenizers#1639

They're waiting for more upstream changes. ⏳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant