ci: add requests compatiblity check #312
Draft
+112
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
tdstein
force-pushed
the
tdstein/requests-compat
branch
3 times, most recently
from
5ef29e8
to
20a9244
Compare
tdstein
force-pushed
the
tdstein/requests-compat
branch
from
20a9244
to
3a8651a
Compare
| - '2.2.0' | ||
| - '2.1.0' | ||
| - '2.0.1' | ||
| - '2.0.0' |
There was a problem hiding this comment.
This feels like overkill. Why not just test on 2.0.0, and if we find that we need to add a specific version later, we can?
There was a problem hiding this comment.
You're probably right. This is just an attempt at understanding where things break. This latest commit is broken, but if you look here, you will see that things break starting with 2.27.1 and earlier. This issue stems from how we are catching errors in the hooks module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.