-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option to use grid for global layout #2516
Open
liu-ziyang
wants to merge
22
commits into
poooi:master
Choose a base branch
from
liu-ziyang:enable-isolated-plugin-tab
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e6b6053
Disable tab key to avoid moving the window accidentally
liu-ziyang d42efa0
Add configuration for isolated tab
liu-ziyang 76bcd4e
remove accidental commit
liu-ziyang a0f8a69
Merge branch 'poooi:master' into enable-isolated-plugin-tab
liu-ziyang ac9cde2
moved grid layout config to panel section
liu-ziyang 0cc52c9
Merge branch 'enable-isolated-plugin-tab' of github.com:liu-ziyang/po…
liu-ziyang 3398e27
revert accidental changes
liu-ziyang 1e14cb3
Merge branch 'poooi:master' into enable-isolated-plugin-tab
liu-ziyang 3d432c5
deactivate tab if grid panel
liu-ziyang 9d72b79
wrap poi with grid
liu-ziyang 8d8abe9
grid layout iteration 1
liu-ziyang 549ce77
undo unnecessary file change
liu-ziyang 41135d6
adjust layout config
liu-ziyang 022ae37
wrap the poi app in the grid
liu-ziyang 14fdca9
update arrangement for the layout
liu-ziyang e9388d2
Merge branch 'master' of github.com:liu-ziyang/poi into enable-isolat…
liu-ziyang 45f92f3
undo change that attempts to hide main page to debug
liu-ziyang 44a8577
add configuration
liu-ziyang d589a81
clean ups
liu-ziyang 78e4c93
clean ups
liu-ziyang f406ed8
add game draggable
liu-ziyang 674d209
Merge branch 'master' of github.com:liu-ziyang/poi into enable-isolat…
liu-ziyang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KochiyaOcean There are 2 approach I am trying, the first one is leaving the poi app outside the grid, which resulted in the control panel taking over the whole screen and I can't figure out how to resize it.
The other approach is put this as a div like other components, I personally prefer doing so because it would then allow moving the control panel around. but if I do that, somehow the control will completely disappear even though the grid item is there and draggable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the poi app is wrapped in the grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may caused by
PoiApp
component is actually a fragment and some event bundling failed to work. Maybe you can check the console to find if there is any js wise errors. In the other way, if the DOM compoents are mounted correctly, it would be more likely to be a css issueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to get devtools to show up again but couldn't figure out what event bundling is broken, there are many error messages and don't seem to be relevant to my untrained eye. any theory based on file change in this PR?