Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Polkadot Wiki Migration] Upgrade Your Node #36
base: master
Are you sure you want to change the base?
[Polkadot Wiki Migration] Upgrade Your Node #36
Changes from 4 commits
a749a43
f4888dd
207b0ea
fd8248a
32ec1c5
7e67af7
4b779ff
801fdb9
4518d17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be a quick overview of which steps are needed with a more extensive tutorial somewhere else? If there isn't a more detailed tutorial to go with this, then some of these steps should have more detail. What commands do I use to start a second node? How do I generate session keys? etc. This section has a nice amount of "what" but almost no "how"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are steps they most likely (if not, someone on their team) would have already gone through when setting up the original validator.
I would just add a link to the onboarding page, which will include how to get a node up and running and how to generate session keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another note: I think this page will get heavily updated at some point, so I would link to other places for now where needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked the "How to Validate" page, which covers this as a prerequisite. We can definitely make it flow a little better, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above. Do we need more how in here or will there be tutorial(s) to link out to?