Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves content to transactions page #101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dawnkelly09
Copy link
Collaborator

This PR does the following:

  1. Moves content from PR [Substrate.io Migration] - Polkadot Protocol > Protocol Components > Transactions > Transactions LifeCycles #78 and PR [Substrate.io Migration] - Polkadot Protocol > Protocol Components > Transactions > Transactions Formats #80 to new IA home at polkadot-protocol/basics/blocks-transactions-fees/transactions.md
  2. Moves and one code snippet and one image related to the above and updates related paths
  3. Deletes old content pages that are not part of new IA

A note about Blocks page: There was a paragraph mixed into Transactions that felt like it should go to Blocks. I commented it out for the moment until I get to the existing pages for the rest of the Block content.

@dawnkelly09 dawnkelly09 requested a review from a team as a code owner October 17, 2024 21:10
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job with this! ✨ For such a long page, I really don't have too many comments haha

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! LGTM! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants